feat(thirdparty): Use facebook/rocksdb and pegasus-kv/encfs as rocksdb thirdparty #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
changed the title
GehaFearless
reviewed
Nov 9, 2023
|
The tests failed because they were still using the old thirdparty libs, including librocksdb.a, which did support the new encryption uri. |
empiredan
approved these changes
Nov 9, 2023
foreverneverer
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the reimplementation of encryption feature on RocksDB as a plugin,
now we can use the facebook official RocksDB plus the pegasus-kv/encfs
plugin. It would be more flexiable rather than modify the core code of
RocksDB.