refactor(thirdparty): Bump googletest to 1.14.0 #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
bump_gtest
branch
from
a7f8b7a to
20e74b0
Compare
acelyc111
force-pushed
the
bump_gtest
branch
from
225c9b4 to
c54f29d
Compare
acelyc111
force-pushed
the
bump_gtest
branch
from
30edc7f to
77b2cbb
Compare
levy5307
approved these changes
Nov 23, 2023
foreverneverer
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch update the googletest to 1.14.0 which is the lateset release currently.
The s2 CMake options have to be changed because it depends on googletest, I will
update these again soon in a following patch.
IWYU generate many changes automatically in this patch, most of them are change
including gtest/gtest.h from angle brackets to quotes, we will fix in another
patch(it's a TODO in #1349)
The changes in src/block_service/test/hdfs_service_test.cpp is one of the benfits
of bump googletest to 1.14.0, now we can use
GTEST_SKIP()macro.This patch also add the missing parameterized for
cold_backup_context_test.