feat: source config_hdfs.sh automatically before starting onebox #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GehaFearless
approved these changes
Dec 5, 2023
empiredan
approved these changes
Dec 5, 2023
GehaFearless
pushed a commit
to GehaFearless/incubator-pegasus
that referenced
this pull request
Feb 28, 2024
…che#1708) When run Pegasus to use the feature of backup data to HDFS (restore data from HDFS is the same), it's needed to set the CLASSPATH enviroment variables, now it is done by scripts/config_hdfs.sh. However, we have to source this script manually before starting onebox. This patch sources the script in ./run.sh automatically, updates config_hdfs.sh to download hadoop package is it's not exist, and removes explicilt calling of scripts/config_hdfs.sh in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run Pegasus to use the feature of backup data to HDFS (restore data from
HDFS is the same), it's needed to set the CLASSPATH enviroment variables, now
it is done by scripts/config_hdfs.sh. However, we have to source this script
manually before starting onebox.
This patch sources the script in ./run.sh automatically, updates config_hdfs.sh
to download hadoop package is it's not exist, and removes explicilt calling of
scripts/config_hdfs.sh in CI.