fix(learn): avoid learn use DEFAULT_POOL #2126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2024 10:29
FLAGS_max_copy_rate_megabytes_per_disk will use `sleep_for` function to block THREAD_POOL_DEFAULT. It's cause replica server cannot deal `remote command`. This modify is same as FLAGS_max_send_rate_megabytes_per_disk, only use THREAD_POOL_BLOCK_SERVICE to sleep. relate issue:apache#1969
ruojieranyishen
force-pushed
the
avoid_learn_use_default_pool
branch
from
37b4579 to
5f338df
Compare
ruojieranyishen
changed the title
acelyc111
previously approved these changes
Dec 4, 2024
|
@ruojieranyishen Thanks for the contribution! Please fix the CI errors. |
acelyc111
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLAGS_max_copy_rate_megabytes_per_disk will use
sleep_forfunction to block THREAD_POOL_DEFAULT. It's cause replica server cannot dealremote command. This modify is same as FLAGS_max_send_rate_megabytes_per_disk, only use THREAD_POOL_BLOCK_SERVICE to sleep.What problem does this PR solve?
relate issue:#1969
avoid learn use DEFAULT_POOL.
Before fix, many partitions ballot increase, and remote_command cannot get response.
After fix, return to normal.