fix undo log parser type jackson not found #690
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luky116
reviewed
Nov 13, 2024
pkg/client/config_test.go
Outdated
| @@ -158,7 +158,7 @@ func TestLoadJson(t *testing.T) { | |||
|
|
|||
| assert.NotNil(t, cfg.ClientConfig.UndoConfig) | |||
| assert.Equal(t, false, cfg.ClientConfig.UndoConfig.DataValidation) | |||
| assert.Equal(t, "jackson222", cfg.ClientConfig.UndoConfig.LogSerialization) | |||
| assert.Equal(t, "json", cfg.ClientConfig.UndoConfig.LogSerialization) | |||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The undo log parser type can be configured through the configuration file.
Currently only supports json.
Which issue(s) this PR fixes:
Fixes #664
fix undo log parser type jackson not found
Special notes for your reviewer:
The reason for the error in seata-go-samples is that an old version with an unpatched undo log parser type is being used. Once the new version of seata-go is released and the dependencies are updated in the samples library, the "undo log parser type jackson not found" error will no longer appear. The main reason for this issue is that
Jacksonis a JSON implementation for Java, not for Go, and changing it tojsonin the configuration file will resolve the problem.Does this PR introduce a user-facing change?:
none