Skip to content

optimize : support multi-version codec & fix not returning client registration failure msg #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: 2.x
Choose a base branch
from

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Nov 14, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. support multi-version(sdk-version) codec
  2. fix not returning client registration failure msg (AbstractIdentifyResponseCodec call super.decode())
  3. compatible old-version-codec in rm-reg/tm-reg

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Bughue Bughue changed the title optimize : support multi-version(sdk-version) codec & fix not returning client registration failure msg [WIP]optimize : support multi-version(sdk-version) codec & fix not returning client registration failure msg Nov 14, 2024
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 41.08527% with 76 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (44dd9d6) to head (74c01a2).

Files with missing lines Patch % Lines
...eata/serializer/seata/MultiVersionCodecHelper.java 0.00% 15 Missing ⚠️
...che/seata/core/rpc/netty/MultiProtocolDecoder.java 0.00% 10 Missing ⚠️
...ache/seata/serializer/seata/MultiVersionCodec.java 0.00% 10 Missing ⚠️
...a/protocol/v2/AbstractIdentifyResponseCodecV2.java 62.96% 4 Missing and 6 partials ⚠️
...serializer/seata/serializer/SeataSerializerV1.java 65.38% 8 Missing and 1 partial ⚠️
...he/seata/serializer/seata/MessageCodecFactory.java 33.33% 2 Missing and 2 partials ⚠️
...che/seata/core/rpc/netty/v1/ProtocolEncoderV1.java 0.00% 3 Missing ⚠️
...che/seata/core/rpc/netty/v0/ProtocolDecoderV0.java 0.00% 2 Missing ⚠️
...che/seata/core/rpc/netty/v0/ProtocolEncoderV0.java 0.00% 2 Missing ⚠️
...che/seata/core/rpc/netty/v1/ProtocolDecoderV1.java 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7000      +/-   ##
============================================
- Coverage     53.46%   53.36%   -0.10%     
- Complexity     7109     7118       +9     
============================================
  Files          1169     1178       +9     
  Lines         41578    41669      +91     
  Branches       4873     4886      +13     
============================================
+ Hits          22229    22238       +9     
- Misses        17250    17328      +78     
- Partials       2099     2103       +4     
Files with missing lines Coverage Δ
.../apache/seata/core/protocol/ProtocolConstants.java 0.00% <ø> (ø)
...apache/seata/core/protocol/RegisterRMResponse.java 100.00% <100.00%> (ø)
...apache/seata/core/protocol/RegisterTMResponse.java 100.00% <100.00%> (ø)
...che/seata/core/rpc/netty/NettyClientBootstrap.java 55.55% <100.00%> (ø)
...n/java/org/apache/seata/core/protocol/Version.java 66.66% <0.00%> (-1.63%) ⬇️
...che/seata/core/rpc/netty/v2/ProtocolDecoderV2.java 50.00% <50.00%> (ø)
...che/seata/core/rpc/netty/v2/ProtocolEncoderV2.java 50.00% <50.00%> (ø)
...eata/core/rpc/processor/server/RegRmProcessor.java 15.15% <0.00%> (-0.48%) ⬇️
...eata/core/rpc/processor/server/RegTmProcessor.java 13.88% <0.00%> (-0.40%) ⬇️
...apache/seata/serializer/seata/SeataSerializer.java 26.66% <50.00%> (-21.82%) ⬇️
... and 13 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bughue Bughue changed the title [WIP]optimize : support multi-version(sdk-version) codec & fix not returning client registration failure msg optimize : support multi-version(sdk-version) codec & fix not returning client registration failure msg Mar 14, 2025
@Bughue Bughue changed the title optimize : support multi-version(sdk-version) codec & fix not returning client registration failure msg optimize : support multi-version codec & fix not returning client registration failure msg Mar 14, 2025
Bughue added 2 commits March 14, 2025 18:59
…ev-register-fail-reason

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@Bughue Bughue requested review from funky-eyes and slievrly March 15, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant