Skip to content

Commit

Permalink
[#2188] fix(client): Fixup timeoutMs for executeTasks in ShuffleWrite…
Browse files Browse the repository at this point in the history
…ClientImpl#sendAppHeartbeat (#2189)

### What changes were proposed in this pull request?

 Fixup timeoutMs for executeTasks in ShuffleWriteClientImpl#sendAppHeartbeat

### Why are the changes needed?

The `timeoutMs` in ShuffleWriteClientImpl#sendAppHeartbeat method. The timeoutMs for per RPC is similar to the timeoutMs of ThreadUtils#executeTasks` for all servers RPC execute, and the logic here is flawed. 

Resetting the `timeoutMs` for `ThreadUtils.executeTask`.

Fix: #2188 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

no need
  • Loading branch information
xumanbu authored Dec 19, 2024
1 parent 8c55030 commit 0481f21
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ public void sendAppHeartbeat(String appId, long timeoutMs) {
}
return null;
},
timeoutMs,
timeoutMs * allShuffleServers.size() / heartBeatThreadNum,
"send heartbeat to shuffle server");
if (coordinatorClient != null) {
coordinatorClient.scheduleAtFixedRateToSendAppHeartBeat(request);
Expand Down

0 comments on commit 0481f21

Please sign in to comment.