Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-6286] Add new query optimize rule: Use TopKNode to replace SortNode when order by expression + limit N #11834

Merged
merged 18 commits into from
Jan 10, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Jan 3, 2024

Description

  1. Before optimize, align by time + order by expression + limit N will use SortNode + LimitNode.

1.1 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 limit 5

image

1.2 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 offset 10 limit 5
image

1.3 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 limit 5
image

1.4 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 offset 10 limit 5
image

  1. After optimize, align by time + order by expression + limit N will use TopKNode.

2.1 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 limit 5
image

2.2 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 offset 10 limit 5
image

2.3 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 limit 5
image

2.4 explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 offset 10 limit 5
image

@Beyyes Beyyes changed the title Align by time + order by + limit N use TopKNode Align by time + order by expression + limit N use TopKNode Jan 3, 2024
@Beyyes Beyyes changed the title Align by time + order by expression + limit N use TopKNode use TopKNode when Align by time + order by expression + limit N Jan 3, 2024
@Beyyes Beyyes changed the title use TopKNode when Align by time + order by expression + limit N Use TopKNode when Align by time + order by expression + limit N Jan 3, 2024
@Beyyes Beyyes changed the title Use TopKNode when Align by time + order by expression + limit N [IOTDB-6286] Add new query optimize rule: Use TopKNode to replace SortNode when order by expression + limit N Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (8e567c5) 48.91% compared to head (422fe79) 48.99%.
Report is 6 commits behind head on master.

Files Patch % Lines
...zation/OrderByExpressionWithLimitChangeToTopK.java 58.66% 62 Missing ⚠️
...queryengine/plan/planner/TemplatedLogicalPlan.java 0.00% 4 Missing ⚠️
...b/queryengine/plan/planner/LogicalPlanBuilder.java 94.44% 1 Missing ⚠️
...ngine/plan/planner/plan/node/process/FillNode.java 0.00% 1 Missing ⚠️
...ine/plan/planner/plan/node/process/OffsetNode.java 0.00% 1 Missing ⚠️
...ngine/plan/planner/plan/node/process/SortNode.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11834      +/-   ##
============================================
+ Coverage     48.91%   48.99%   +0.08%     
- Complexity    25616    25676      +60     
============================================
  Files          2908     2909       +1     
  Lines        181650   181838     +188     
  Branches      21758    21798      +40     
============================================
+ Hits          88854    89098     +244     
+ Misses        92796    92740      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JackieTien97 JackieTien97 merged commit 6a478f6 into master Jan 10, 2024
36 of 37 checks passed
@JackieTien97 JackieTien97 deleted the beyyes/align_by_time_topk branch January 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants