-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-6286] Add new query optimize rule: Use TopKNode to replace SortNode when order by expression + limit N #11834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11834 +/- ##
============================================
+ Coverage 48.91% 48.99% +0.08%
- Complexity 25616 25676 +60
============================================
Files 2908 2909 +1
Lines 181650 181838 +188
Branches 21758 21798 +40
============================================
+ Hits 88854 89098 +244
+ Misses 92796 92740 -56 ☔ View full report in Codecov by Sentry. |
JackieTien97
requested changes
Jan 5, 2024
...rg/apache/iotdb/db/queryengine/plan/optimization/OrderByExpressionWithLimitChangeToTopK.java
Show resolved
Hide resolved
...rg/apache/iotdb/db/queryengine/plan/optimization/OrderByExpressionWithLimitChangeToTopK.java
Show resolved
Hide resolved
...rg/apache/iotdb/db/queryengine/plan/optimization/OrderByExpressionWithLimitChangeToTopK.java
Outdated
Show resolved
Hide resolved
...rg/apache/iotdb/db/queryengine/plan/optimization/OrderByExpressionWithLimitChangeToTopK.java
Show resolved
Hide resolved
...rg/apache/iotdb/db/queryengine/plan/optimization/OrderByExpressionWithLimitChangeToTopK.java
Outdated
Show resolved
Hide resolved
|
JackieTien97
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SortNode + LimitNode
.1.1
explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 limit 5
1.2

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 offset 10 limit 5
1.3

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 limit 5
1.4

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 offset 10 limit 5
TopKNode
.2.1

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 limit 5
2.2

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d1.s1 offset 10 limit 5
2.3

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 limit 5
2.4

explain select * from root.sg1.d1,root.sg1.d2 order by root.sg1.d3.s1 offset 10 limit 5