Feat/resettable singletons #11870
Closed
Feat/resettable singletons #11870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngletons for allowing to switch the storage location at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are using singletons throughout the code-base. This has the disadvantage that once these are initialized, we can't re-initialize them. Especially when running IoTDB in an embedded mode, this makes it impossible to switch the storage location.
I've added "reinitializeStatics()" methods to places, were I needed to have them re-initialized.
This is actually just a hack or workaround needed till we refactor IoTDB to be a cleanly modeled fo useage of a DI framework.