Pipe: Modify the TableRawReq deserialization method to support directconversion to TableStatement. #16844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can add some tests to prove that the time consumed is reduced |
Member
Author
done |
jt2594838
reviewed
Dec 8, 2025
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java
Show resolved
Hide resolved
- Optimize times array copy: skip copy when lengths are equal, use System.arraycopy - Add warning logs when times array is null or too small - Ensure all arrays (values, times, bitMaps) are copied to rowSize length for immutability - Filter out null columns when converting Statement to Tablet - Rename idColumnIndices to tagColumnIndices - Add skipString method to avoid constructing temporary objects - Add comments explaining skipped fields in readMeasurement - Use direct buffer position increment instead of reading bytes for skipping - Ensure all column values are copied to ensure immutability
JackieTien97
pushed a commit
that referenced
this pull request
Dec 10, 2025
…conversion to TableStatement. (#16844) * Pipe: Modify the TableRawReq deserialization method to support direct conversion to TableStatement. * fix * fix * fix * fix * fix * update * update * update * refactor: optimize TabletStatementConverter according to code review - Optimize times array copy: skip copy when lengths are equal, use System.arraycopy - Add warning logs when times array is null or too small - Ensure all arrays (values, times, bitMaps) are copied to rowSize length for immutability - Filter out null columns when converting Statement to Tablet - Rename idColumnIndices to tagColumnIndices - Add skipString method to avoid constructing temporary objects - Add comments explaining skipped fields in readMeasurement - Use direct buffer position increment instead of reading bytes for skipping - Ensure all column values are copied to ensure immutability * update * update (cherry picked from commit 13b0582)
JackieTien97
pushed a commit
that referenced
this pull request
Dec 11, 2025
…conversion to TableStatement. (#16844) * Pipe: Modify the TableRawReq deserialization method to support direct conversion to TableStatement. * fix * fix * fix * fix * fix * update * update * update * refactor: optimize TabletStatementConverter according to code review - Optimize times array copy: skip copy when lengths are equal, use System.arraycopy - Add warning logs when times array is null or too small - Ensure all arrays (values, times, bitMaps) are copied to rowSize length for immutability - Filter out null columns when converting Statement to Tablet - Rename idColumnIndices to tagColumnIndices - Add skipString method to avoid constructing temporary objects - Add comments explaining skipped fields in readMeasurement - Use direct buffer position increment instead of reading bytes for skipping - Ensure all column values are copied to ensure immutability * update * update (cherry picked from commit 13b0582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A comparison before and after optimization shows that the deserialization performance is improved by 4.5 times after optimization.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR