-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-19069: DumpLogSegments does not dump the LEADER_CHANGE record #19729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. Could you add related test case?
Done. Thanks. |
@@ -351,6 +333,32 @@ object DumpLogSegments { | |||
} finally fileRecords.closeHandlers() | |||
} | |||
|
|||
private[tools] def printControlRecord(record: Record): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to add [tools]
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Done, thanks.
Description:
Add case for dumping LEADER_CHANGE record in DumpLogSegments.
Verification
Before:
After:
Reviewers: PoAn Yang payang@apache.org, Chia-Ping Tsai
chia7712@gmail.com