Skip to content

Expose jetty metrics #7045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Expose jetty metrics #7045

wants to merge 2 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Apr 24, 2025

Why are the changes needed?

Expose the jetty metrics to help detect issue.
Refer: https://metrics.dropwizard.io/4.2.0/manual/jetty.html

How was this patch tested?

image image

Was this patch authored or co-authored using generative AI tooling?

No.

@turboFei turboFei changed the title metrics Expose jetty metrics Apr 24, 2025
@turboFei turboFei self-assigned this Apr 24, 2025
@turboFei turboFei requested a review from pan3793 April 24, 2025 21:36
@turboFei turboFei force-pushed the metrics_jetty branch 3 times, most recently from 2d3f977 to 157bf60 Compare April 24, 2025 22:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (29b6076) to head (122b93f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...thentication/KyuubiHttpAuthenticationFactory.scala 0.00% 8 Missing ⚠️
...ache/kyuubi/server/KyuubiRestFrontendService.scala 0.00% 3 Missing ⚠️
...cala/org/apache/kyuubi/metrics/MetricsSystem.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7045   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         695     695           
  Lines       42833   42842    +9     
  Branches     5833    5835    +2     
======================================
- Misses      42833   42842    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei added this to the v1.11.0 milestone Apr 25, 2025
@turboFei turboFei closed this in 4cbff4d Apr 25, 2025
turboFei added a commit that referenced this pull request Apr 25, 2025
### Why are the changes needed?

Expose the jetty metrics to help detect issue.
Refer: https://metrics.dropwizard.io/4.2.0/manual/jetty.html

### How was this patch tested?

<img width="1425" alt="image" src="https://github.com/user-attachments/assets/ac8c9a48-eaa1-48ee-afec-6f33980d4270" />

<img width="1283" alt="image" src="https://github.com/user-attachments/assets/c2fa444b-6337-4662-832b-3d02f206bd13" />

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7045 from turboFei/metrics_jetty.

Closes #7045

122b93f [Wang, Fei] metrics
45a73e7 [Wang, Fei] metrics

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Wang, Fei <fwang12@ebay.com>
(cherry picked from commit 4cbff4d)
Signed-off-by: Wang, Fei <fwang12@ebay.com>
@turboFei turboFei deleted the metrics_jetty branch April 25, 2025 07:03
@turboFei
Copy link
Member Author

thanks, merged to 1.11.0 and 1.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants