Add support for LMAX Disruptor 4.x #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
requested changes
Dec 20, 2023
log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigDisruptor.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/apache/logging/log4j/core/async/DefaultAsyncWaitStrategyFactory.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerDisruptor.java
Outdated
Show resolved
Hide resolved
ppkarwasz
added a commit
to ppkarwasz/logging-log4j2
that referenced
this pull request
Dec 20, 2023
vy
requested changes
Dec 20, 2023
log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java
Show resolved
Hide resolved
Fixes apache#1829 Signed-off-by: tomerarazy <tomerarazy@gmail.com>
An additional test run will ensure `log4j-core` works with Disruptor 4.x.
ppkarwasz
force-pushed
the
lmax-disruptor-4-0-0
branch
from
b7877be to
461d18d
Compare
|
Hi @ppkarwasz, thank you for fixing this but I can't see the new version in the released notes? Or we should wait for the next 3.X version? |
|
@Alanoudj, this will be made available in Log4j 3 will use Disruptor 4, there Disruptor 3 is completely removed. |
|
Do you have any deadline for 2.23.0 version release? |
|
The |
jackshirazi
added a commit
to jackshirazi/logging-log4j2
that referenced
this pull request
Jul 25, 2024
During startup with an agent, the resulting object can be in the wrong classloader leading to a ClassCastException. Catching that falls back to the old behaviour which works fine The new behaviour was introduced in 2.23.0 with apache#2112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1937 and adds support for LMAX Disruptor 4.x by:
EventHandlerclasses into two versions: one for 3.x and 4.x,TimeoutBlockingWaitStrategy,Closes #1829