Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transitive compileOnlyApi (requires static) dependencies #3450

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

jjohannes
Copy link

This pull requests adds compileOnlyApi dependencies (Gradle Module Metadata) and requires static (module-info) for all annotation libraries used in Log4j. See #3437 for details.

The following example can be used to test the effects of the change in a Gradle build on a locally built snapshot:
https://github.com/jjohannes/gradle-demos/tree/main/log4j-metadata

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

See apache#3437 for details.

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
@vy
Copy link
Member

vy commented Feb 10, 2025

@jjohannes, I've just released logging-parent version 12.0.0. It contains breaking changes touching these dependencies. dependabot should automatically update logging-parent version in /pom.xml. Would you mind keeping an eye on it, and once the update kicks in, make necessary adjustments to this PR, please?

@vy
Copy link
Member

vy commented Feb 10, 2025

@ppkarwasz, shall we also add a test for this to log4j-samples?

Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants