Fix formatting of s pattern
#3469
Merged
+58
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specialized `SecondPatternSequence` formatter is optimized to format the `ss.?S*` patterns, where seconds are padded. For the not padded (and uncommon) `s` pattern, we should use the usual `DynamicPatternSequence`.
vy
reviewed
Feb 17, 2025
...java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternDynamicFormatter.java
Outdated
Show resolved
Hide resolved
vy
approved these changes
Feb 19, 2025
...java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternDynamicFormatter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specialized
SecondPatternSequenceformatter is optimized to format thess.?S*patterns, where seconds are padded. For the not padded (and uncommon)spattern, we should use the usualDynamicPatternSequence.This is the main reason for the failing #3468 test.