-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reopen method in PerThreadPKLookup #13596
Conversation
Please take a look when you get a chance. |
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java
Outdated
Show resolved
Hide resolved
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
@jpountz |
I can't figure out what can we reuse from prior If we want reuse prior For the situation of PK, every PK has different @jpountz Please correct me if I am wrong. |
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java
Outdated
Show resolved
Hide resolved
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java
Outdated
Show resolved
Hide resolved
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java
Outdated
Show resolved
Hide resolved
lucene/test-framework/src/java/org/apache/lucene/tests/index/PerThreadPKLookup.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to look at your PR locally to understand what it did. It looked good to me but I saw a few simplifications I wanted to make, such as not caching null
TermsEnum, since returning null
Terms is not expensive on a reader. I felt free to push to your branch, I hope you don't mind. The change looks good to me.
This change looks clearer, Thanks @jpountz . |
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Co-authored-by: Adrien Grand <jpountz@gmail.com>
Description
Reuse loaded segments'
termsEnum
andpostingsEnum
.