Failing test for early termination in DrillSideways #15221
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will do so when allowEarlyTermination is set to "true" and the hitCollector early terminates with a CollectionTerminatedException. Note that this only works for the sequential case, since parallel will use a separate collection for each dimension
|
Added an implementation using a dedicated collector for DrillSideways that can bubble up the early termination. This works for the sequential case, but it won't work for the concurrent case, since in concurrent, we are collecting directly with the sideways collector. For the concurrent case, each sideways facet collector should early terminate on it's own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Failing test that shows there is no early termination in DrillSideways when the hit collector throws
CollectionTerminatedException. This test would pass in Lucene 8.10. Related to #15220