Update some asserts in search tests #15251
Open
+16,254
−15,691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2BinaryQuantizedVectorsFormat (apache#15222)
Slowly moving the legacy formats to the backwards codecs. I have most of the logic moved, but there are additional things to figure out. I don't think we can easily move the Lucene99ScalarQuantizedVectorScorer just yet, but we should be able to prevent users from using the old quantized formats.
…s for non-accountable query size (apache#15124) * Use RamUsageEstimator to calculate query size instead of the default 1024 bytes for non accountable queries * Use try-with-resources for directory and indexWriter * Adding changes to cache query size and queries per clause to reduce impact of repeated visit() calls during RamUsageEstimator.sizeOf() * Adding changelog entry * Making queries per clause list immutable * Adding unit test to verify query size is cached correctly * Renmaing QueryMetadata to Record * Changing query metadata to record type and removing boolean query changes
Fix some issues found by `actionlint`, `shellcheck`, and `zizmor -p` More issues remain, this is just incremental progress.
… cherry picked from the patch by @kaivalnp apache#15240 (apache#15241)
Co-authored-by: Kaival Parikh <kaivalp2000@gmail.com>
…e array filter applied and never cache dictionaries from custom locations (apache#15237) * Fix SmartChinese to only serialize data from classpath with a native array filter applied and never cache dictionaries from custom locations * fix exception handling * add CHANGES.txt * fix exception handling * fix typo in CHANGES.txt * Restore the code to regenerate the serialized file * Disallow any serialization in test-framework as early as possible (we can't do that via sysprops due to Gradle) * Install a serialization filter that only allows Gradle's test runner config deserialization * fix errorprone * use same logic like for security manager to install the filter * add new filter to CHANGES.txt * Improve performance by only installing a filter if we're not called from Gradle * simplify * Add a test for the deserialization filter * fix typo * improve test
…rce leak in existence check (apache#15248)
thecoop
added
the
skip-changelog
thecoop
force-pushed
the
search-test-asserts
branch
from
263d809 to
4948003
Compare
thecoop
force-pushed
the
search-test-asserts
branch
from
4948003 to
1e45010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
assertThatand friends rather than opaque boolean conditions in some tests inorg.apache.lucene.search