Skip to content

Commit

Permalink
Lucene.Net.Util.LuceneRandomSeedInitializer: Removed TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
NightOwl888 committed Jan 27, 2025
1 parent b156bb6 commit 347ad09
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ private static bool TryGetRandomSeedsFromContext(Test test, out long seed, out l
return false;
}

// LUCENENET TODO: For now, we are ignoring anything after a colon in the string, but logically it seems like
// a second seed would be to set the a test so the RandomAttribute fails on the first iteration. Lucene uses a compound
// seed, but it isn't clear from analyzing the source how it is used, just that it can contain any number of colon delimited
// values. If we ignore now, we leave the door open for adding a compound seed in the most sensible way later without breaking
// the current version when the change is introduced.
if (!J2N.Numerics.Int64.TryParse(seedAsString.AsSpan(colonIndex + 1, seedAsString.Length - (colonIndex + 1)), radix: 16, out long testSeedValue))
{
test.MakeInvalid(RANDOM_SEED_PARAMS_MSG);
Expand Down

0 comments on commit 347ad09

Please sign in to comment.