Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated basic_gates.md #492

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Updated basic_gates.md #492

merged 1 commit into from
Feb 6, 2025

Conversation

krishna-dave206
Copy link
Contributor

@krishna-dave206 krishna-dave206 commented Feb 6, 2025

Updated the Basic Gates Section.

Some gates in basic gates section were outdated and needed to be updated with the new ones. Updated them all.

Updated the Basic Gates Section.
@krishna-dave206
Copy link
Contributor Author

@andrewmusselman I have updated the basic gates section in which the outdated ones have been replaced with the new ones. Please review it and if everything works fine as expected, kindly merge this PR. Also, if there's still any update needed or something you think that I missed out, then feel free to let me know, I'll update it.

@rawkintrevo
Copy link
Contributor

Thank you for the contribution @krishna-dave206 !

Merging because even if the tests fail, it has nothing to do with the markdown

@rawkintrevo rawkintrevo merged commit 2909c29 into apache:main Feb 6, 2025
1 check passed
@krishna-dave206
Copy link
Contributor Author

Thanks for merging the PR @rawkintrevo looking forward to contribute more. Do. let me know if there are other fixes that has to be made.

@rawkintrevo
Copy link
Contributor

thanks @krishna-dave206 i'm out of pocket on some family stuff, so I appologize for the slow turn around on getting back to you. If you check out https://github.com/apache/mahout/tree/main/website/quantum-computing-primer that for sure was all done ... quickly. there's probably errors throughout, and towards the later parts, it definitely gets a bit suspect. Ie. there's entire example in there that could probably be commented out. (comment them out, don't just delete them, we would like to re-enable them when we have enough commands to do so, or if you want to be really cool, 'invent' new methods that don't exist yet, then put # proposed method, does not yet exist on the line).

Other than that, join the mailing list, and if you're able, we have a community call on fridays, i'm hoping to make it this week.
tagging in @andrewmusselman too, he's more in pocket this week and may be able to respond quicker.

@krishna-dave206
Copy link
Contributor Author

Thanks for informing @rawkintrevo I'd definitely like to contribute further by joining the mailing list. Just for my convenience, at what time does the meetings occur? As I need to adjust my college timings accordingly.
Also, I'll make the changes you stated and raise the PR again. I'm a student from India and looking forward to work with you.
Regards,
Krishna Dave

@krishna-dave206
Copy link
Contributor Author

@rawkintrevo @andrewmusselman Also, it would be kind if you can provide specific error type in the https://github.com/apache/mahout/tree/main/website/quantum-computing-primer
as it has too many files and documentation. It would be great if you can provide me with the section in which the error exists and the example section where the error exists.
Regards,
Krishna Dave

@krishna-dave206
Copy link
Contributor Author

krishna-dave206 commented Feb 12, 2025 via email

@rawkintrevo
Copy link
Contributor

Lol / /shame another thing you could do would be making this more prominent on the website.

https://mahout.apache.org/community/mailing-lists.html

@krishna-dave206
Copy link
Contributor Author

@rawkintrevo Thanks for the link, I've joined the mailing list. I'll be present in the upcoming community call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants