Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and Pull request templates #502

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

vedansh-5
Copy link
Contributor

Purpose of PR:
This PR improves the issue and pull request templates in the .github/ directory to enhance clarity, usability, and contributor experience.

Changes Made:
Added separate issue templates for Bug Reports, Feature Requests, and Documentation Issues.
Implemented auto-labeling for issue categorization.

Closes #496

@vedansh-5
Copy link
Contributor Author

@rawkintrevo: I have made the requested changes, can you review when you get some time? Thanks!

Copy link
Contributor

@rawkintrevo rawkintrevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more lines need uncommented, and one nit. Thank you!

---

### Description
<!-- A clear and concise description of the bug. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I wasn't clear, I meant uncomment all of these. They're good notes, but when they're commented, people won't see them.


### Linked Issues
Add links to related issues.
- Fixes MAHOUT-XXXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit, but since you need to uncomment the lines in the other file anyway, replace this line with

Closes #123

@vedansh-5 vedansh-5 requested a review from rawkintrevo March 3, 2025 22:19
Copy link
Contributor

@rawkintrevo rawkintrevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you dropped the entire section of ## Related Issues? Can you add it back?



Closes #123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you dropped the section header and - Related to #123 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see from the UI why- I just met that one line, not all three lines. Sorry/blame github.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought you wanted all those lines replaced, reverting this right away. Sorry for the confusion.

@vedansh-5 vedansh-5 requested a review from rawkintrevo March 3, 2025 22:28
Copy link
Contributor

@rawkintrevo rawkintrevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rawkintrevo rawkintrevo merged commit 6da6756 into apache:main Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve GitHub Issue and PR Templates
2 participants