-
Notifications
You must be signed in to change notification settings - Fork 960
MAHOUT-604: Add test for single qubit gates #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@robinanil Nice to meet you! Could I join the community? |
|
cc @rawkintrevo |
|
I’ll review this one tomorrow, thanks for your contribution! |
|
@guan404ming thanks! |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, overall looks good.
I think we could paramatized our tests instead of hard-coded test one case. To using paramatized could make our tests more flexiable to include new test cases in the future.
|
@guan404ming Ok, I'll try to modify it as soon as possible. |
|
@guan404ming I've tried to make changes. |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@guan404ming thanks! |
Purpose of PR
This PR is first part of
test_single_qubit_gates.py.This file is split into 3 cumulative PRs including those tests:
This PR is about tests of them: TestPauliXGate , TestPauliYGate and TestPauliZGate.
You can test this PR locally with command:
Related Issues or PRs
#604
Changes Made
Breaking Changes
Checklist