Skip to content

Conversation

@rich7420
Copy link
Contributor

@rich7420 rich7420 commented Nov 7, 2025

Purpose of PR

This PR is first part of test_single_qubit_gates.py.
This file is split into 3 cumulative PRs including those tests:

TestPauliXGate
TestPauliYGate
TestPauliZGate
TestPauliZGate.test_pauli_z_with_hadamard
TestHadamardGate
TestNOTGate
TestUGate
TestSingleQubitGatesEdgeCases
TestSingleQubitGatesConsistency

This PR is about tests of them: TestPauliXGate , TestPauliYGate and TestPauliZGate.

You can test this PR locally with command:

pytest testing/test_single_qubit_gates.py

Related Issues or PRs

#604

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

@rich7420
Copy link
Contributor Author

rich7420 commented Nov 7, 2025

@robinanil Nice to meet you! Could I join the community?

@guan404ming
Copy link
Member

cc @rawkintrevo

@guan404ming
Copy link
Member

I’ll review this one tomorrow, thanks for your contribution!

@rich7420
Copy link
Contributor Author

rich7420 commented Nov 7, 2025

@guan404ming thanks!

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, overall looks good.

I think we could paramatized our tests instead of hard-coded test one case. To using paramatized could make our tests more flexiable to include new test cases in the future.

@rich7420
Copy link
Contributor Author

rich7420 commented Nov 8, 2025

@guan404ming Ok, I'll try to modify it as soon as possible.

@rich7420
Copy link
Contributor Author

rich7420 commented Nov 8, 2025

@guan404ming I've tried to make changes.

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guan404ming guan404ming merged commit 2c7f6e6 into apache:main Nov 9, 2025
4 checks passed
@rich7420
Copy link
Contributor Author

rich7420 commented Nov 9, 2025

@guan404ming thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants