fix bugs: stabilize htmlContent by normalizing tableRows whitespace/boundary events #1017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MarkdownParserTest#testHtmlContentwas brittle around HTML tables.Inside
<table><tbody>…</tbody></table>, the event stream intermittently included extra"text"whitespace nodes and"unknown"nodes (tbody boundary markers), which caused order-sensitive assertions to fail (e.g., expecting text but seeingtableRow/tableHeaderCell_). This is environmental/renderer dependent and shows up under different JDKs/runners and with NonDex.Design / Implementation
assertSinkEquals(...)block for this test with a compact normalization loop:tableRows…tableRows_.Scope is only
htmlContent; no production code touched, no new imports or dependencies.Reproduce the error
org.apache.maven.doxia.module.markdown.MarkdownParserTest.htmlContent -- Time elapsed: 0.869 s <<< FAILURE! org.opentest4j.AssertionFailedErrormvn -pl doxia-modules/doxia-module-markdown edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.maven.doxia.module.markdown.MarkdownParserTest#htmlContentFollowing this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.