-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to md #70
Convert to md #70
Conversation
src/site/markdown/download.md.vm
Outdated
|
||
${esc.h}${esc.h} Mirror | ||
|
||
\[if-any logo\] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slawekjaranowski Is this still supposed to be used like this? I am not sure which placeholders are replaced by the CGI (documentation at https://infra.apache.org/release-download-pages.html#custom is very sparse). Mirrors are gone nowadays...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is just very few placeholders available for use in the template: https://maven.apache.org/skins/maven-fluido-skin/download.cgi?asjson=true, the templating language is described in https://github.com/gstein/ezt/blob/wiki/Syntax.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First I would like to update download page like in apache/maven-changes-plugin#68
we will not a special cgi for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a globally provided template is some more efforted I refactored now the download page to a more simple version (no longer mentioning any mirrors). However it still relies on the placeholder mechanism of the underlying closer.lua script due to reasons outlined at https://issues.apache.org/jira/browse/MSKINS-240?focusedCommentId=17902720&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17902720
from revision apache/maven-doxia-converter@6bdce4c and apache/maven-doxia@ac99291 Some manual polishing applied afterwards, particularly to reconstruct velocity macros/expressions
No description provided.