Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to md #70

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Convert to md #70

merged 3 commits into from
Dec 6, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Dec 2, 2024

No description provided.


${esc.h}${esc.h} Mirror

\[if-any logo\]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawekjaranowski Is this still supposed to be used like this? I am not sure which placeholders are replaced by the CGI (documentation at https://infra.apache.org/release-download-pages.html#custom is very sparse). Mirrors are gone nowadays...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just very few placeholders available for use in the template: https://maven.apache.org/skins/maven-fluido-skin/download.cgi?asjson=true, the templating language is described in https://github.com/gstein/ezt/blob/wiki/Syntax.md.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First I would like to update download page like in apache/maven-changes-plugin#68
we will not a special cgi for it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a globally provided template is some more efforted I refactored now the download page to a more simple version (no longer mentioning any mirrors). However it still relies on the placeholder mechanism of the underlying closer.lua script due to reasons outlined at https://issues.apache.org/jira/browse/MSKINS-240?focusedCommentId=17902720&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17902720

@kwin kwin marked this pull request as ready for review December 5, 2024 17:18
@kwin kwin merged commit 797b9cd into master Dec 6, 2024
4 of 9 checks passed
@kwin kwin deleted the convert-to-md branch December 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants