Bugfix/77 make project build again #1252
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to verify changes by a Maven build cf. support-and-care/maven-support-and-care#77
Inject an interface, not a particular implementation (which ceased to exist with Maven 4). (Cf. support-and-care/maven-support-and-care#77).
Merged
cstamas
added a commit
that referenced
this pull request
Feb 8, 2025
Seems MSC fork does not allow pushes from users who have commit rights on forked maven-mvnd, so am incorporating @ascheman changes here as well. This PR is: * fixes from PR #1252 * plus fix SO isse (self injected cache) * plus migrated whole daemon to Maven DI (from javax.inject) except those that override Sisu components * ported latest Maven changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft solves some compile errors (as discussed in Slack with @gnodet).
But it completely breaks the integration tests (They produce very long stack traces by now).
Happy to get some feedback.