This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
METRON-2357: Extends example 4 with a dynamic version #47
base: master
Are you sure you want to change the base?
METRON-2357: Extends example 4 with a dynamic version #47
Changes from 1 commit
5a4db2b
ea4a516
91b75e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the goal of the
|Kafka::logs_to_send| == 0 ||
portion of this? My read of this is this could get confusing because this example ignores ourlogs_to_exclude
andsend_all_active_logs
options, if they also get set in an environment following this example config. Is there a way we can refactor this, potentially leveragingsend_to_kafka
to make it more robust?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @JonZeolla I just improve this part of the example by removing the condition, it still works the same. I also had some confusions about that line
|Kafka::logs_to_send| == 0 ||
but now is all clear so it isn't need at all.