nimble/bttester: Add manual EATT connection control to BTP tester #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-czapracki
changed the title
szymon-czapracki
force-pushed
the
btp_eatt_conn
branch
from
9455791 to
4b0182a
Compare
sjanc
requested changes
Jun 24, 2025
apps/bttester/src/btp_gatt.c
Outdated
| ble_gap_conn_find_handle_by_addr(&cp->address, &conn_handle); | ||
|
|
||
| rc = ble_eatt_connect(conn_handle, cp->num_channels); | ||
| if (rc == BLE_HS_EALREADY) { |
There was a problem hiding this comment.
this check doesn't seem valid, I'd suggest something like
if (rc == 0 || rc == BLE_HS_EALREADY) {
return BTP_STATUS_SUCCESS;
}
return BTP_STATUS_FAILED;
(or reverse logic if you prefer to have success as 'default' case)
szymon-czapracki
force-pushed
the
btp_eatt_conn
branch
from
4b0182a to
ea0a2ef
Compare
Adds new BTP command `BTP_GATT_EATT_CONNECT` (opcode 0x1f) to trigger
EATT connections with configurable L2CAP channels.
Implements handler `eatt_conn()` that:
* Calls `ble_eatt_connect()` with the requested channel count
and proper address
Enables testing scenarios requiring explicit control over EATT establishment
and channel management.
szymon-czapracki
force-pushed
the
btp_eatt_conn
branch
from
ea0a2ef to
3b102b1
Compare
MariuszSkamra
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new BTP command
BTP_GATT_EATT_CONNECT(opcode 0x1f) to triggerEATT connections with configurable L2CAP channels.
Implemented handler
eatt_conn()that:ble_eatt_connect()with the requested channel count and proper addressUpdated
supported_commandsresponse to advertise the new capability.Enables testing scenarios requiring explicit control over EATT establishment and channel management.