#8174: Bump ide/libs.tomljava #8192
Open
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiro
added
kind:bug
yeah, I am thinking about adding a check list with links to the guides etc. Although for lib updates like here - no list will help you ;) Someone has to figure out where the lib is used and make sure the right tests run or when in doubt:
ci:all-tests
|
Signed-off-by: Antonio Vieiro <antonio@vieiro.net>
|
Hi @mbien . Thanks for pointing this out. Amended (and rebased on master). Let's see how it goes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #8174 . The library now emits an
INVALIDtoken for unclosed inline arrays and tables.Maybe we can add a link to the message above that points to the meaning of each label? It seems we have many labels now...