-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-14367 Removed casting to BufferedInputStream in PublishKafka #9804
base: main
Are you sure you want to change the base?
Conversation
- Keeping original input stream during Kafka publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change @sammu97 - would you mind adding a unit test or integration test to confirm the change / fix?
Hi @pvillard31 , sure will do. Will need to give some thought about how to best go about testing this. |
Hi @pvillard31 , I've added 2 tests for the KafkaRecordConverter, however am finding it difficult to mock a RecordStreamKafkaRecordConverter and RecordWrapperStreamKafkaRecordConverter due to the RecordSetWriterFactory and RecordReaderFactory objects needed. Would appreciate some guidance here |
- Added further tests for KafkaRecordConverter and refactored existing code - Added License headers
Hi @pvillard31 , I have added further tests for all KafkaRecordConverter classes, let me know what you think. |
Great @pvillard31 , thank you and looking forward to having this released 😄 |
Summary
NIFI-14367
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation