Wasm.mk: disable by default #2065
Conversation
|
do anyone still have any concerns? |
|
@yamt I'm sorry to cause you trouble, and I think it's reasonable to add an option to control this behavior. Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. In the future, I will reorganize the implementation related to the Wasm compilation system to make it more reasonable and user-friendly (for example, researching the possibility of using wasi as a build target). |
|
@xiaoxiang781216 I think we should land this patch first because there are indeed users who use WAMR on NuttX, but they don't need to build applications from within NuttX. This way, the current behavior of compiling certain applications (such as coremark) into Wasm modules by default when the Wasm runtime is enabled will cause unnecessary trouble for them. |
i have no problem with the name. |
it's a pure nuttx option, why need append _FOR_NUTTX_LIBC? INTERPRETERS_WAMR_BUILD_MODULES is enough to represent the intent. |
In fact, these modules from NuttX's build system shared the same difinition with native NuttX (such as sys/types.h and fcntl.h), they can only works with NuttX now even some function signature is compatible with WAMR's builtin libc. |
wasm modules are often expected more "run anywhere" than eg. ELF objects. |
Ok, but it's better to remove _LIBC suffix from the option since many non libc api can expose too. |
ok, it makes sense. |
|
@yamt please change INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX, thanks. |
yamt
force-pushed
the
disable-wasm
branch
2 times, most recently
from
ab10a56 to
b1ecffc
Compare
done |
but could you sqaush into one patch? |
Fixes partly: apache#2046 Also, this fixes warnings like: ``` spacetanuki% ./tools/configure.sh -E sim:wamr Copy files Select CONFIG_HOST_MACOS=y Refreshing... /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory CP: arch/dummy/Kconfig to /Users/yamamoto/git/nuttx/nuttx/arch/dummy/dummy_kconf ig CP: boards/dummy/Kconfig to /Users/yamamoto/git/nuttx/nuttx/boards/dummy/dummy_k config /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory /usr/local/bin/bash: line 1: /bin/clang: No such file or directory ```
done |
Summary
Fixes partly: #2046
Impact
Testing