Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netutils: introduce libwebsockets support #2733

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Oct 15, 2024

Summary

  1. netutils: introduce libwebsockets support
  2. Fix to compile failure after mqttc is enabled

Impact

Testing

Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
@nuttxpr
Copy link

nuttxpr commented Oct 15, 2024

[Experimental Bot, please feedback here]

No, the provided PR summary lacks details.

Missing Information:

  • Detailed explanation of changes:
    • What is the purpose of introducing libwebsockets support?
    • What specific compilation failure was addressed in the mqttc fix? How was it fixed?
  • Impact Assessment:
    • The "Impact" section is entirely empty. You must address each impact area:
      • Will this add features, change existing ones?
      • How will it impact users (configuration, usage)?
      • Will the build process change (new dependencies, options)?
      • Which hardware architectures, boards, or drivers are affected?
      • Is documentation impacted (updates needed or provided)?
      • Are there security implications?
      • Is backward/forward compatibility or interoperability affected?
  • Testing Details:
    • You haven't provided any information about your testing environment.
      • What host OS, CPU, and compiler did you use for building?
      • Which target architectures and boards did you test on? Were they real hardware or simulators?
    • The "Testing logs" sections are empty. You need to provide actual logs demonstrating the issue before the change and the successful outcome after the change.

To meet the NuttX PR requirements, you need to:

  1. Expand the Summary: Provide specific details about the changes and their purpose.
  2. Complete the Impact Assessment: Address all impact areas thoroughly.
  3. Provide Detailed Testing Information: Describe your testing environment and include relevant logs.

Remember, a well-documented PR is crucial for reviewers to understand and approve your changes.

Signed-off-by: wangyingdong <wangyingdong@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 47c8d37 into apache:master Oct 16, 2024
36 checks passed
@W-M-R W-M-R deleted the net branch October 16, 2024 10:03
$(LIBWEBSOCKETS_UNPACK)/lib/roles/http/client/client-http.c \
$(LIBWEBSOCKETS_UNPACK)/lib/event-libs/poll/poll.c

CSRCS += \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be wrapped with if for MBED_TLS config?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@W-M-R please take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants