Skip to content

Commit

Permalink
ORC-1618: Disable building tests for snappy
Browse files Browse the repository at this point in the history
Disabling the building of tests is a workaround for issue #1791 and is probably not an issue since snappy tests are not executed as part of the build process of orc c++ libs.

Note that snappy 1.1.9 and 1.1.10 cannot be used as is because source assets on snappy's gh page are not buildable out of the box, so stick to 1.1.8 for now.

### What changes were proposed in this pull request?
Disable  building snappy tests as a workaround for issue #1791.

### Why are the changes needed?
compilation broken in some situations otherwise (see issue)

### How was this patch tested?
compile & unit tests

### Was this patch authored or co-authored using generative AI tooling?
no

Closes #1792 from douardda/fix-snappy.

Authored-by: David Douard <david.douard@sdfa3.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 9627a24)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
  • Loading branch information
douardda authored and dongjoon-hyun committed Feb 14, 2024
1 parent 5bf5227 commit b5c4e0b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake_modules/ThirdpartyToolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ else ()

ExternalProject_Add (snappy_ep
URL "https://github.com/google/snappy/archive/${SNAPPY_VERSION}.tar.gz"
CMAKE_ARGS ${SNAPPY_CMAKE_ARGS}
CMAKE_ARGS ${SNAPPY_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF
${THIRDPARTY_LOG_OPTIONS}
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")

Expand Down

0 comments on commit b5c4e0b

Please sign in to comment.