Skip to content

[core] Skip processed sequence group fields to improve performance of PartialUpdateMergeFunction #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] Skip processed sequence group fields to improve performance of PartialUpdateMergeFunction #6345

wants to merge 1 commit into from

Conversation

liyubin117
Copy link
Contributor

@liyubin117 liyubin117 commented Sep 28, 2025 •
edited
Loading

Purpose

Skip processed sequence group fields to improve performance of PartialUpdateMergeFunction

  1. skip null sequence group fields
  2. skip sequence group fields have been updated at once
  3. move seqComparator != null check forward for common case optimization

Tests

PartialUpdateMergeFunctionTest

@liyubin117 liyubin117 force-pushed the fasten_partial_update branch 2 times, most recently from da97bfe to b393b2a Compare September 28, 2025 06:12
@liyubin117
Copy link
Contributor Author

liyubin117 commented Sep 28, 2025 •
edited
Loading

@JingsongLi All CI succeeded extra non-related hive metastore issue, PTAL, thanks :)
CI succeeded in my repo.
image

@liyubin117 liyubin117 force-pushed the fasten_partial_update branch from b393b2a to 1afe5a6 Compare September 29, 2025 02:21
@liyubin117
Copy link
Contributor Author

@JingsongLi CI succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liyubin117