support millisecond timestamps in iceberg compatibility mode #6352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Falk <gfalk@yelp.com>
|
Please fix |
Signed-off-by: Max Falk <gfalk@yelp.com>
Signed-off-by: Max Falk <gfalk@yelp.com>
Done, i've also updated the docs |
|
@JingsongLi good to merge? |
0dunay0
approved these changes
Oct 1, 2025
JingsongLi
reviewed
Oct 13, 2025
| "Paimon Iceberg compatibility only support timestamp type with precision from 4 to 6."); | ||
| timestampPrecision >= 3 && timestampPrecision <= 6, | ||
| "Paimon Iceberg compatibility only support timestamp type with precision from 3 to 6."); | ||
| return Timestamp.fromMicros(timestampLong); |
There was a problem hiding this comment.
If precision is 3, this long should be a millis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This adds to #4318 by allowing Paimon millisecond type to be converted to the canonical microseconds in Iceberg.
We ingest data from Kafka and other sources into Paimon and our Iceberg-based Data Lake. Kafka timestamps and some business data has timestamps with millisecond precision. This allows supporting that type of data without any type changes required in the ingestion pipeline.
Tests
IcebergConversionsTimestampTest.java