PDFBOX-5660: split large method

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1923761 13f79535-47bb-0310-9956-ffa450edef68
apache · Feb 12, 2025 · 6eafc4e · 6eafc4e
1 parent 91408d9
commit 6eafc4e
Showing 1 changed file with 30 additions and 21 deletions.
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java b/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
@@ -1547,32 +1547,13 @@ public void shadingFill(COSName shadingName) throws IOException
     public void showAnnotation(PDAnnotation annotation) throws IOException
     {
         lastClips = null;
-        if (destination == RenderDestination.PRINT && !annotation.isPrinted())
-        {
-            return;
-        }
-        if ((destination == RenderDestination.VIEW || destination == RenderDestination.EXPORT) &&
-                annotation.isNoView())
-        {
-            return;
-        }
-        if (annotation.isHidden())
-        {
-            return;
-        }
-        if (annotation.isInvisible() && annotation instanceof PDAnnotationUnknown)
-        {
-            // "If set, do not display the annotation if it does not belong to one
-            // of the standard annotation types and no annotation handler is available."
-            return;
-        }
-        //TODO support NoZoom, example can be found in p5 of PDFBOX-2348
 
-        if (isHiddenOCG(annotation.getOptionalContent()))
+        if (shouldSkipAnnotation(annotation))
         {
             return;
         }
 
+        //TODO support NoZoom, example can be found in p5 of PDFBOX-2348
         PDAppearanceDictionary appearance = annotation.getAppearance();
         if (appearance == null || appearance.getNormalAppearance() == null)
         {
@@ -1606,6 +1587,34 @@ public void showAnnotation(PDAnnotation annotation) throws IOException
         }
     }
 
+    private boolean shouldSkipAnnotation(PDAnnotation annotation)
+    {
+        if (destination == RenderDestination.PRINT && !annotation.isPrinted())
+        {
+            return true;
+        }
+        if ((destination == RenderDestination.VIEW || destination == RenderDestination.EXPORT) &&
+                annotation.isNoView())
+        {
+            return true;
+        }
+        if (annotation.isHidden())
+        {
+            return true;
+        }
+        if (annotation.isInvisible() && annotation instanceof PDAnnotationUnknown)
+        {
+            // "If set, do not display the annotation if it does not belong to one
+            // of the standard annotation types and no annotation handler is available."
+            return true;
+        }
+        if (isHiddenOCG(annotation.getOptionalContent()))
+        {
+            return true;
+        }
+        return false;
+    }
+
     private boolean hasTransparency(PDFormXObject form) throws IOException
     {
         if (form == null)