rework symlink test #445
rework symlink test #445
Conversation
There was a problem hiding this comment.
Nothing immediate jumps out at me but I would get @jrudolph to check just to make sure nothing is missed
lgtm
|
|
||
| // need to serve from the src directory, when sbt copies the resource directory over to the | ||
| // target directory it will resolve symlinks in the process | ||
| val testRoot = new File("http-tests/src/test/resources") |
There was a problem hiding this comment.
Better with Files.path, and yes Winodws is using different separator
There was a problem hiding this comment.
So TIL that Windows has symlinks but only for Windows 10/11. I don't know how this factors into everything, my initial inclination is to disable the test for Windows since this seems to only really be testing behaviour specific to Posix systems.
@He-Pin Can you confirm if the test passes on your machine (assuming all of the Windows related path separator issues have been solved)?
There was a problem hiding this comment.
This line is copied from an existing test. The test either works or fails on Windows - either way noone is complaining about it.
There was a problem hiding this comment.
My understanding is that Windows Java installs know how to apply the file path even if it doesn't use Windows idioms.
There was a problem hiding this comment.
@He-Pin could you try running sbt http-tests/test? It doesn't take that long compared to similar commands in main pekko repo.
* rework symlink test * add test that uses temp file symbolic link (still not fully working) * Update FileAndResourceDirectivesSymlinkSpec.scala * Update FileAndResourceDirectivesSymlinkSpec.scala
#275, #444