Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double timeout on flaky test #314

Merged
merged 1 commit into from
Sep 26, 2024
Merged

double timeout on flaky test #314

merged 1 commit into from
Sep 26, 2024

Conversation

pjfanning
Copy link
Contributor

see #216

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we already set pekko.test.timefactor for GitHub Actions builds (https://pekko.apache.org/docs/pekko/current/general/configuration-reference.html#pekko-testkit), but this is OK in any case.

@pjfanning
Copy link
Contributor Author

The same flaky test failed even with the timefactor=2 - but the timefactor didn't seem to increase the timeout - it still looks like the same same short 1.5 second timeout.

[info] - should be able to be created *** FAILED *** (1 second, 459 milliseconds)
[info]   The future returned an exception of type: org.apache.pekko.coordination.lease.LeaseTimeoutException, with message: Timed out removing lease [lease-1]. It is not known if the remove happened. Is the API server up?. (KubernetesApiSpec.scala:104)
[info]   org.scalatest.exceptions.TestFailedException:

@raboof
Copy link
Member

raboof commented Sep 26, 2024

hmm, maybe because this test explicitly sets it to testKitSettings.DefaultTimeout.duration? What happens when we remove that? sorry for leading you down this rabbit hole :/

@pjfanning
Copy link
Contributor Author

pjfanning commented Sep 26, 2024

Without the explicit patience config, things get far worse. All the individual scenarios timeout in 150ms (each).

@pjfanning pjfanning marked this pull request as draft September 26, 2024 14:15
@pjfanning pjfanning marked this pull request as ready for review September 26, 2024 15:32
@pjfanning
Copy link
Contributor Author

I'll merge the original change that just doubles the time on the patience config in this test class.

@pjfanning pjfanning merged commit 6f970c6 into apache:main Sep 26, 2024
30 checks passed
@pjfanning pjfanning deleted the flaky-test branch September 26, 2024 15:33
@raboof raboof mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants