Configuration option to enable gzip compression on k8s pods api for service discovery #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for service discovery
pjfanning
reviewed
Oct 16, 2024
...api/src/main/scala/org/apache/pekko/discovery/kubernetes/KubernetesApiServiceDiscovery.scala
Show resolved
Hide resolved
pjfanning
reviewed
Oct 16, 2024
pjfanning
reviewed
Oct 16, 2024
discovery-kubernetes-api/src/main/scala/org/apache/pekko/discovery/kubernetes/Settings.scala
Outdated
Show resolved
Hide resolved
…address review findings
pjfanning
reviewed
Oct 16, 2024
discovery-kubernetes-api/src/main/scala/org/apache/pekko/discovery/kubernetes/Settings.scala
Outdated
Show resolved
Hide resolved
|
There is support for integration testing in the integration-test directory. This includes an existing K8s test. Maybe you could modify this to use gzip. |
… adjust "kubernetes-api-java" integration-test to use gzip compression
Ah, yes .. I overlooked the integration-tests. |
pjfanning
approved these changes
Oct 17, 2024
|
@pjfanning could you rerun the failed unit test? |
|
Merged - thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #335
Feedback is very welcome, I am not very experienced in Scala.