Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix deprecated IntegrationTest #165

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Mar 30, 2024

IntegrationTest currently not working on my IDEA, It keeps complaining about NoClassFound.

After following the changes in the sbt release notes guidance, it works fine on my IDEA: https://eed3si9n.com/sbt-1.9.0

@Roiocam Roiocam requested review from pjfanning and mdedetrich and removed request for pjfanning March 30, 2024 13:28
@pjfanning
Copy link
Contributor

pjfanning commented Mar 30, 2024

Any idea why the Check Code Style CI build is failing when it is looking for pekko-persistence-jdbc-core? This jar seems never to have been published before.

Edit: I have commented on the build.sbt change that is causing the failure.

build.sbt Outdated Show resolved Hide resolved
@Roiocam Roiocam requested a review from He-Pin March 30, 2024 15:38
@Roiocam Roiocam marked this pull request as draft March 30, 2024 16:48
@Roiocam Roiocam marked this pull request as ready for review March 31, 2024 01:13
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Roiocam Roiocam merged commit 4dcaddb into apache:main Mar 31, 2024
20 checks passed
@Roiocam Roiocam deleted the deprecated-it branch March 31, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants