Feedback: Updating logback-classing version + scalaVersion.

apache · Oct 2, 2023 · 7a565d6 · 7a565d6
1 parent 7e69e7a
commit 7a565d6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/pekko-sample-grpc-kubernetes-scala/build.sbt b/pekko-sample-grpc-kubernetes-scala/build.sbt
@@ -1,5 +1,5 @@
 name := "pekko-grpc-kubernetes"
-scalaVersion := "2.13.3"
+scalaVersion := "2.13.11"
 
 lazy val pekkoVersion = "1.0.1"
 lazy val discoveryVersion = "1.0.0"
@@ -25,11 +25,12 @@ lazy val httpToGrpc = (project in file("http-to-grpc"))
 
       "org.apache.pekko" %% "pekko-discovery-kubernetes-api" % discoveryVersion,
 
-      "ch.qos.logback" % "logback-classic" % "1.2.3"
+      "ch.qos.logback" % "logback-classic" % "1.4.11"
     ),
     dockerExposedPorts := Seq(8080),
   )
 
+// gRPC back end that echoes back messages
 lazy val grpcService = (project in file("grpc-service"))
   .enablePlugins(PekkoGrpcPlugin, DockerPlugin, JavaAppPackaging)
   .settings(
@@ -43,8 +44,6 @@ lazy val grpcService = (project in file("grpc-service"))
 
       "org.apache.pekko" %% "pekko-http" % pekkoHttpVersion,
 
-      "ch.qos.logback" % "logback-classic" % "1.2.3"
+      "ch.qos.logback" % "logback-classic" % "1.4.11"
     )
   )
-
-
diff --git a/pekko-sample-grpc-kubernetes-scala/http-to-grpc/src/main/resources/logback.xml b/pekko-sample-grpc-kubernetes-scala/http-to-grpc/src/main/resources/logback.xml
@@ -18,4 +18,4 @@
         <appender-ref ref="ASYNC"/>
     </root>
 
-</configuration>
+</configuration>
diff --git a/pekko-sample-grpc-kubernetes-scala/kubernetes/httptogrpc.yml b/pekko-sample-grpc-kubernetes-scala/kubernetes/httptogrpc.yml
@@ -58,4 +58,4 @@ spec:
               service:
                 name: httptogrpc
                 port:
-                  number: 8080
+                  number: 8080