add k8s port check #106
Merged
add k8s port check #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
requested changes
May 6, 2024
| @@ -33,4 +33,9 @@ pekko.management { | |||
| example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck | |||
| } | |||
| } | |||
| # Add these so the pods won't get killed. | |||
| http { | |||
| port = 8558 | |||
There was a problem hiding this comment.
You could also set it to bind-port instead of port(port is fine too).
If the user does not want to change, they just need to set it to pekko-management port in the k8s health check.(is 7626 not 8558)
Roiocam
reviewed
May 10, 2024
There was a problem hiding this comment.
@pjfanning Can you update this as the default pekko port? I think this configuration is still indeed for user understanding. Thanks!
pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf
Outdated
Show resolved
Hide resolved
pekko-sample-cluster-kubernetes-scala/src/main/resources/application.conf
Outdated
Show resolved
Hide resolved
…ation.conf Co-authored-by: AndyChen(Jingzhang) <iRoiocam@gmail.com>
…cation.conf Co-authored-by: AndyChen(Jingzhang) <iRoiocam@gmail.com>
Roiocam
approved these changes
May 10, 2024
| @@ -33,4 +33,9 @@ pekko.management { | |||
| example-ready = org.apache.pekko.cluster.bootstrap.demo.DemoHealthCheck | |||
| } | |||
| } | |||
| # Expose port for Kubernetes health check probing. | |||
There was a problem hiding this comment.
Sorry, I forgot the comment should be clarity. I have updated this in the commit, I hope you don't mind.
And then I think this is ready for review.
Thanks.
There was a problem hiding this comment.
looks good now - thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #103