Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce issue where stackoverflow happens in unstash #1336

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented May 21, 2024

see #1327

This doesn't cause the test to fail or abort - for some reason testkit/scalatest logs the stackoverflow but then claims no tests were run.

Uncaught error from thread [EventSourcedStashOverflowSpec-pekko.actor.default-dispatcher-9]: null, shutting down JVM since 'pekko.jvm-exit-on-fatal-error' is enabled for ActorSystem[EventSourcedStashOverflowSpec]
java.lang.StackOverflowError
	at org.apache.pekko.actor.typed.internal.StashBufferImpl.unstash(StashBufferImpl.scala:206)
[info] Run completed in 3 seconds, 635 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[info] No tests to run for persistence-typed-tests / Test / testOnly

Without this PR change, the test runs and succeeded: 1 is logged.

@pjfanning pjfanning marked this pull request as draft May 21, 2024 18:26
@pjfanning
Copy link
Contributor Author

pjfanning commented May 21, 2024

I have a possible solution but it is breaking quite a few tests so it needs more debugging. It is only one approach but by passing back a behavior wrapping the unstash instead of running the unstash in place - this avoids stack overflow issues.
The broken tests show that it is not quite this simple and it may prove to be a dead end.

@pjfanning
Copy link
Contributor Author

I have a possible solution but it is breaking quite a few tests so it needs more debugging. It is only one approach but by passing back a behavior wrapping the unstash instead of running the unstash in place - this avoids stack overflow issues. The broken tests show that it is not quite this simple and it may prove to be a dead end.

This 'solution' isn't working out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants