Fetch the query quota capacity utilization rate broker metric in a callback function #12767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhtaoxiang Can you help take a look? |
jasperjiaguo
reviewed
May 9, 2024
|
|
||
| @VisibleForTesting | ||
| @Override | ||
| int getHitCount(long now) { |
There was a problem hiding this comment.
Should this be getHitCount()? Otherwise finalQueryQuotaEntity.getMaxQpsTracker().getHitCount(); would be calling into the base class impl? Am I missing smth here?
There was a problem hiding this comment.
Good question! The call of finalQueryQuotaEntity.getMaxQpsTracker().getHitCount() will call the getHitCount() method from the base class, which internally invokes the int getHitCount(long now) method in the child class. So we should be good here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fetches the query quota capacity utilization rate broker metric in a callback function.
Related issue: #12768
The reason is that this broker metric is a gauge metric. If there is no incoming query, the gauge value would remain the same without any updates. In addition, if the total query quota is less than the number of brokers, meaning if the per-broker rate is less than 1, the metric value would always be > 100. So even there is only 1 incoming query for a while, the metric value would still be > 100.