Set column major segment builder to be on by default

[ege-st]

This enables the faster Column Major segment builder to be on by default. This feature has been in the wild for several months and since it's purpose is to speed up segment building it makes sense to enable it by default.

Effect:

1. Any new table will be configured to use column major segment building.
2. I believe any existing table will continue to use row major segment building unless the config is updated manually.

Testing:

1. Ran locally to verify that tables used column major segment building.
2. Ran unit tests to make sure they all passed.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.58%. Comparing base (59551e4) to head (a7836b7).
Report is 191 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #12770      +/-   ##
============================================
- Coverage     61.75%   61.58%   -0.17%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2463      +27     
  Lines        133233   134745    +1512     
  Branches      20636    20822     +186     
============================================
+ Hits          82274    82982     +708     
- Misses        44911    45568     +657     
- Partials       6048     6195     +147     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	61.53% <100.00%> (-0.18%)	⬇️
java-21	61.45% <100.00%> (-0.17%)	⬇️
skip-bytebuffers-false	61.57% <100.00%> (-0.18%)	⬇️
skip-bytebuffers-true	34.43% <100.00%> (+6.70%)	⬆️
temurin	61.58% <100.00%> (-0.17%)	⬇️
unittests	61.58% <100.00%> (-0.17%)	⬇️
unittests1	46.19% <100.00%> (-0.70%)	⬇️
unittests2	27.94% <0.00%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[siddharthteotia]

To clarify, this is enabling the column major segment builder for the RT / consuming to immutable segment conversion. Correct ?

I am guessing this column major builder is both space efficient and faster right ?

[ege-st]

Correct. This is for RT conversion and is much faster.

…

On Thu, Apr 4, 2024, 2:49 AM Siddharth Teotia ***@***.***> wrote: To clarify, this is enabling the column major segment builder for the RT / consuming to immutable segment conversion. Correct ? I am guessing this column major builder is both space efficient and faster right ? — Reply to this email directly, view it on GitHub <#12770 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BAASDJ5PXJ4KELN3KPXYGT3Y3TZXDAVCNFSM6AAAAABFSIT532VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGMZDGMJTGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>