Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable sketch accuracy in merge rollup task #14373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davecromberge
Copy link
Member

Merge rollup task feature enhancement 2

Adds the capability to configure sketch precision / accuracy for different rollup buckets. This can result in a space saving for use cases where historical data does not require high accuracy

See: #14310

release-notes:

  • New configuration options

@davecromberge
Copy link
Member Author

NOTE: This PR is a work in progress and has been created to demonstrate the concept

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 16 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (59551e4) to head (8d6697f).
Report is 1278 commits behind head on master.

Files with missing lines Patch % Lines
...aggregator/DistinctCountThetaSketchAggregator.java 0.00% 6 Missing ⚠️
...ssing/aggregator/IntegerTupleSketchAggregator.java 0.00% 6 Missing ⚠️
...t/processing/framework/SegmentProcessorConfig.java 50.00% 2 Missing and 1 partial ⚠️
...ache/pinot/plugin/minion/tasks/MergeTaskUtils.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14373      +/-   ##
============================================
+ Coverage     61.75%   63.81%   +2.05%     
- Complexity      207     1561    +1354     
============================================
  Files          2436     2660     +224     
  Lines        133233   145948   +12715     
  Branches      20636    22341    +1705     
============================================
+ Hits          82274    93131   +10857     
- Misses        44911    45942    +1031     
- Partials       6048     6875     +827     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.75% <70.37%> (+2.04%) ⬆️
java-21 63.70% <70.37%> (+2.07%) ⬆️
skip-bytebuffers-false 63.80% <70.37%> (+2.05%) ⬆️
skip-bytebuffers-true 63.64% <70.37%> (+35.91%) ⬆️
temurin 63.81% <70.37%> (+2.05%) ⬆️
unittests 63.80% <70.37%> (+2.05%) ⬆️
unittests1 55.51% <46.42%> (+8.62%) ⬆️
unittests2 34.16% <46.29%> (+6.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added enhancement release-notes Referenced by PRs that need attention when compiling the next release notes Configuration Config changes (addition/deletion/change in behavior) ingestion minion labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Config changes (addition/deletion/change in behavior) enhancement ingestion minion release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants