Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TableDataManagerProvider pluggable #14470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

  • Make TableDataManagerProvider pluggable similar to InstanceDataManager
  • Cleanup CommonConstants and HelixInstanceDataManagerConfig to reduce duplications

@Jackie-Jiang Jackie-Jiang added enhancement Configuration Config changes (addition/deletion/change in behavior) cleanup labels Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (59551e4) to head (2c7ee2a).
Report is 1342 commits behind head on master.

Files with missing lines Patch % Lines
.../starter/helix/HelixInstanceDataManagerConfig.java 0.00% 6 Missing ⚠️
...server/starter/helix/HelixInstanceDataManager.java 0.00% 4 Missing ⚠️
.../java/org/apache/pinot/server/conf/ServerConf.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14470      +/-   ##
============================================
+ Coverage     61.75%   63.79%   +2.04%     
- Complexity      207     1566    +1359     
============================================
  Files          2436     2664     +228     
  Lines        133233   146216   +12983     
  Branches      20636    22403    +1767     
============================================
+ Hits          82274    93280   +11006     
- Misses        44911    46044    +1133     
- Partials       6048     6892     +844     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.75% <35.29%> (+2.04%) ⬆️
java-21 63.68% <35.29%> (+2.06%) ⬆️
skip-bytebuffers-false 63.77% <35.29%> (+2.02%) ⬆️
skip-bytebuffers-true 63.66% <35.29%> (+35.94%) ⬆️
temurin 63.79% <35.29%> (+2.04%) ⬆️
unittests 63.79% <35.29%> (+2.04%) ⬆️
unittests1 55.58% <100.00%> (+8.69%) ⬆️
unittests2 34.11% <5.88%> (+6.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKcorps
Copy link
Contributor

KKcorps commented Nov 16, 2024

If someone wants to change only the realtime or offline table data manager, they'll still need to initialise the other one. How do we avoid this?

@Jackie-Jiang
Copy link
Contributor Author

@KKcorps That's why we are making the data manager provider pluggable, and people can choose any data manager to override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Configuration Config changes (addition/deletion/change in behavior) enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants