Modbus Coil/DI array fix, support for Word Swap #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Discrete Input handling when processing response
Fixed endianness resolution to check modbusTag overrides
Fixed response handling for Modbus Coil and Discrete Input arrays
Added support for Modbus Word Swapping
16 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses both #2060 and #2059.
66467ef : The ModbusOptimizer handling for reading Coils and Discrete Inputs didn't check if the response was actually an array of booleans, always returning only the first bit instead of a list of bits in such cases. I added support for checking should the response be handled as a
PlcBOOLorPlcList.cdebad6 : The driver originally had support for Byte Swapping, but it the world of Modbus there is also need for Word Swapping, and even a combination of both. I extended the
ModbusByteOrderto include the new variations. Given, having the different variations in the enum isn't perfect, but it required the least changes and won't break anything. Alternatively these could be as separate options, but I don't think it's worth the effort.