Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] change RoutingMode default from UseSinglePartition to RoundRobinDistribution #286

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TakaHiR07
Copy link
Contributor

@TakaHiR07 TakaHiR07 commented Jun 20, 2023

Motivation

It is more reasonable to set routingMode default RoundRobinDistribution, just as the java client.

Otherwise, user may ignore this config, and producer can not produce msg to all partitions

Modifications

change default routingMode config

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should align the default with the Java client

can you please add a test case ?

This is breaking behaviour change, we should discuss it on the mailing list and we should also take care of not cherry-pick it on maintenance branches, such kind of changes is allowed only on major versions

@shibd shibd added this to the 3.3.0 milestone Jun 20, 2023
@BewareMyPower
Copy link
Contributor

I agree with @eolivelli. It would be good to fix the inconsistency with the Java client, but it would also bring breaking changes. We should discuss it on the mailing list.

@TakaHiR07
Copy link
Contributor Author

I agree that we should align the default with the Java client

can you please add a test case ?

This is breaking behaviour change, we should discuss it on the mailing list and we should also take care of not cherry-pick it on maintenance branches, such kind of changes is allowed only on major versions

Have modified the configuration test to verify default config change. It seems not necessary to add additional test because testRoundRobinRoutingPolicy() is included.

@BewareMyPower BewareMyPower modified the milestones: 3.3.0, 3.4.0 Jul 25, 2023
@BewareMyPower BewareMyPower modified the milestones: 3.4.0, 3.5.0 Nov 1, 2023
@BewareMyPower BewareMyPower removed this from the 3.5.0 milestone Mar 1, 2024
@BewareMyPower
Copy link
Contributor

Hi, @TakaHiR07 is there any chance to resolve the conflicts?

@TakaHiR07 TakaHiR07 force-pushed the improve_change_default_routingMode branch from 91dddb5 to 6dd859d Compare August 20, 2024 02:49
@TakaHiR07
Copy link
Contributor Author

Hi, @TakaHiR07 is there any chance to resolve the conflicts?

@BewareMyPower done.

@BewareMyPower BewareMyPower added this to the 3.6.0 milestone Aug 20, 2024
BewareMyPower
BewareMyPower previously approved these changes Aug 20, 2024
@BewareMyPower
Copy link
Contributor

It seems that there are some existing tests that failed due to this change.

@BewareMyPower BewareMyPower dismissed their stale review August 20, 2024 13:30

Unit tests failed

@shibd shibd modified the milestones: 3.6.0, 3.7.0 Aug 28, 2024
@TakaHiR07
Copy link
Contributor Author

I revert the pr change and this test "testHasMessageAvailableAfterSeekToEnd" still fail. It seems this pr is not the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants