-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][txn] Fix the transaction acknowledgement and send logic for chunk message #1069
Conversation
@liangyepianzhou The bug of producer I have fixed in #1071 |
Maybe you can merge the master after this PR is merged? |
Or you can just fix the consumer, I have refactored the producer, that modified a lot of code. |
Sure, I can only fix the consumer. Thanks for your contribution. |
You are welcome. So, if you are free, would you please help to review my PR #1071. |
…nk message (#1069) Master #1060 ### Motivation 1. For the chunk message, we only register the send operation once but end the send operation multiple times when receiving the send response. It will make the transaction can be committed before all the operations are completed. 2. When we use transaction ack for chunk messages, the provided transaction is ignored, resulting in the chunk message actually being acknowledged using the non-transactional ack method. ### Modifications 1. Only end the send operation when receive the last chunk message. 2. Add the check for the transaction when the massage is a chunk message. (cherry picked from commit 59ef32b)
Master #1060
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation