-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] return when registerSendOrAckOp() failed #1045
Conversation
It's better to add a unit test to cover it. |
@RobertIndie pls merge this PR, I have rebased it to the newest master branch, or it will be outdate some days later. |
@shibd @RobertIndie it seems the CI is broken. |
We need to wait for the CI to be passed before merging the PR. I have rerun the CI. @gunli |
@RobertIndie the comments/imports of this project are of different formats, some comments looks like this: some imports are grouped/sorted by names/std/third-party/projects, some are not grouped/sorted. Would you please standardize the format of comments/imports in the code, otherwise, When I prepare a PR, my IDE(goland) format the comments/imports with one format, and then I have to revert the comments/imports with another editor, it quite painful for me. |
Hi, @gunli. Did you configure the code style of your IDE correctly? I usually use the |
@RobertIndie What I mean is that since Go have provided so many good formatting tools, as a project, it is better to have only ONE format for comments/imports, but currently there are different comment/import formats in our files, it not good for the community contributors. |
@gunli We already have the format convention for the project: https://github.com/apache/pulsar-client-go/blob/master/.golangci.yml . But it seems that currently, there are no restriction rules in place for certain cases like comment formats. But we have the |
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #1040
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #1040
Motivation
fix #1040, return when registerSendOrAckOp() return an error.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation