Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] return when registerSendOrAckOp() failed #1045

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jun 29, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #1040

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #1040

Motivation

fix #1040, return when registerSendOrAckOp() return an error.

Modifications

  • modified: pulsar/producer_partition.go

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@shibd
Copy link
Member

shibd commented Jun 30, 2023

It's better to add a unit test to cover it.

@gunli
Copy link
Contributor Author

gunli commented Jul 4, 2023

@RobertIndie pls merge this PR, I have rebased it to the newest master branch, or it will be outdate some days later.

@gunli
Copy link
Contributor Author

gunli commented Jul 4, 2023

@shibd @RobertIndie it seems the CI is broken.

@gunli gunli mentioned this pull request Jul 4, 2023
@RobertIndie
Copy link
Member

We need to wait for the CI to be passed before merging the PR. I have rerun the CI. @gunli

@gunli
Copy link
Contributor Author

gunli commented Jul 4, 2023

@RobertIndie the comments/imports of this project are of different formats, some comments looks like this:
// this is a comment
and others looks like this:
//this is a comment

some imports are grouped/sorted by names/std/third-party/projects, some are not grouped/sorted.

Would you please standardize the format of comments/imports in the code, otherwise, When I prepare a PR, my IDE(goland) format the comments/imports with one format, and then I have to revert the comments/imports with another editor, it quite painful for me.

@RobertIndie
Copy link
Member

Hi, @gunli. Did you configure the code style of your IDE correctly? I usually use the golangci-lint run --fix to format the code.

@gunli
Copy link
Contributor Author

gunli commented Jul 5, 2023

@RobertIndie What I mean is that since Go have provided so many good formatting tools, as a project, it is better to have only ONE format for comments/imports, but currently there are different comment/import formats in our files, it not good for the community contributors.

@RobertIndie
Copy link
Member

RobertIndie commented Jul 5, 2023

@gunli We already have the format convention for the project: https://github.com/apache/pulsar-client-go/blob/master/.golangci.yml . But it seems that currently, there are no restriction rules in place for certain cases like comment formats. But we have the goimports linter. If you are willing to improve this, I'm happy to review it. Or you could raise an issue and let's talk about it in that issue.

@RobertIndie RobertIndie merged commit aa66471 into apache:master Jul 5, 2023
@RobertIndie RobertIndie added this to the v0.12.0 milestone Jul 11, 2023
RobertIndie pushed a commit that referenced this pull request Sep 7, 2023
Master Issue: #1040

### Motivation

fix #1040, return when registerSendOrAckOp() return an error.

### Modifications

- modified: pulsar/producer_partition.go

---------

Co-authored-by: gunli <gunli@tencent.com>
(cherry picked from commit aa66471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Should we return when transactionImpl.registerSendOrAckOp() returns an error?
3 participants